GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 35 Pull Requests 12 Actions Packages Projects 1 Releases Wiki Activity

修复试玩回包遗漏双端玩法失败证据（#548） #598

Merged
lhk229 merged 3 commits from fix/548 into master 2026-10-03 18:54:13 +08:00
Conversation 1 Commits 3 Files Changed 8
+473 -33
lhk229 commented 2026-10-03 17:24:39 +08:00
Member
Copy Link
Copy Source

试玩报告已记录玩法阻断，但工具回包只展示视觉结果，Agent 无法从“画面正常、整体失败”定位原因；返回的私有报告路径也不能通过通用文件工具读取。

本次增加逐视口 gameplayResults，返回有界诊断、断言和初末状态，并从同一份投影生成摘要。明确区分视觉检查与玩法检查、未通过与未执行；保留现有通过判定、验证预算和私有目录保护。同步更新证据合同、提示词与 skill pack。

验证：

  • Rust 定向测试、提示词构建与源码边界检查通过。
  • 最终 MCP 成功/失败回包均检查逐视口状态、原因、断言及截图。
  • 显式运行 4 个真实浏览器用例：双端成功、禁用控件、真实点击后 phase 未进入 playing、仅移动端失败；对照持久报告核对回包与摘要。
  • rustfmt、编码、文档索引、skill pack、git diff --check 通过。
  • 未运行全量测试或真实模型端到端验证。

Closes #548

试玩报告已记录玩法阻断，但工具回包只展示视觉结果，Agent 无法从“画面正常、整体失败”定位原因；返回的私有报告路径也不能通过通用文件工具读取。 本次增加逐视口 gameplayResults，返回有界诊断、断言和初末状态，并从同一份投影生成摘要。明确区分视觉检查与玩法检查、未通过与未执行；保留现有通过判定、验证预算和私有目录保护。同步更新证据合同、提示词与 skill pack。 验证： - Rust 定向测试、提示词构建与源码边界检查通过。 - 最终 MCP 成功/失败回包均检查逐视口状态、原因、断言及截图。 - 显式运行 4 个真实浏览器用例：双端成功、禁用控件、真实点击后 phase 未进入 playing、仅移动端失败；对照持久报告核对回包与摘要。 - rustfmt、编码、文档索引、skill pack、git diff --check 通过。 - 未运行全量测试或真实模型端到端验证。 Closes #548
lhk229 added 2 commits 2026-10-03 17:24:40 +08:00
修复试玩回包遗漏双端玩法失败证据（#548） 6c0f504c12 
补全逐视口玩法诊断、断言和状态投影，并区分未执行与失败
补充关键回归测试，核对最终工具回包、截图及真实浏览器持久报告
同步试玩证据合同、提示词和技能包指纹
补齐试玩回包审查要求的关键验收（#548）
Project CI / AI game creator shell Rust lane 1/2 (pull_request) Has been cancelled
Details
Project CI / AI game creator shell Rust lane 2/2 (pull_request) Has been cancelled
Details
Project CI / AI game creator shell Rust crates (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Repository checks (pull_request) Has been cancelled
Details
Project CI / AI game creator shell web tests (pull_request) Has been cancelled
Details
1a27e40758 
绑定逐视口摘要中的状态、阻断原因与首个未通过断言
验证成功和失败结果均完整进入最终 MCP 回包
新增真实点击后未进入 playing 的浏览器场景并对照持久报告
收紧视觉未执行断言并补充长期验收要求
lhk229 reviewed 2026-10-03 17:28:08 +08:00
lhk229 left a comment
Author
Member
Copy Link
Copy Source

审查

审查范围：fix/548 相对 master，633355952..1a27e4075，8 个文件。未发现缺陷。

固定场景试玩的双端结果已进入 agc_browser_playtest 回包。每个视口包含通过状态、有界诊断、断言和阶段、序号、关卡；摘要与结构化字段同源。视觉模式写明玩法未执行。回包不读取、不展开 .agent 中的完整私有报告。失败和成功都会进入模型可见的工具文本。

先前「三条分支挤在一个夹具、未执行 误匹配免责声明、成功路径未走模型回包」的测试缺口已由 1a27e4075 补上。

#548

可以随本 PR 关闭。

  • 视觉通过而玩法失败时，回包按 desktop、mobile 给出首条诊断和首个未通过断言。
  • 缺一端时仍保留该视口，并记为 passed=false。
  • 回包 passed 同时受视觉结果和双端玩法门禁约束；视觉模式明确玩法未执行。
  • reportPath 仍只是相对引用，通用读取继续拒绝 .agent。
  • 默认测试分别钉住 start disabled、点击后 phase 仍为 ready、玩法成功，并核对模型可见回包。
## 审查 审查范围：`fix/548` 相对 `master`，`633355952..1a27e4075`，8 个文件。未发现缺陷。 固定场景试玩的双端结果已进入 `agc_browser_playtest` 回包。每个视口包含通过状态、有界诊断、断言和阶段、序号、关卡；摘要与结构化字段同源。视觉模式写明玩法未执行。回包不读取、不展开 `.agent` 中的完整私有报告。失败和成功都会进入模型可见的工具文本。 先前「三条分支挤在一个夹具、`未执行` 误匹配免责声明、成功路径未走模型回包」的测试缺口已由 `1a27e4075` 补上。 ## #548 可以随本 PR 关闭。 - 视觉通过而玩法失败时，回包按 desktop、mobile 给出首条诊断和首个未通过断言。 - 缺一端时仍保留该视口，并记为 `passed=false`。 - 回包 `passed` 同时受视觉结果和双端玩法门禁约束；视觉模式明确玩法未执行。 - `reportPath` 仍只是相对引用，通用读取继续拒绝 `.agent`。 - 默认测试分别钉住 start disabled、点击后 phase 仍为 ready、玩法成功，并核对模型可见回包。
lhk229 added 1 commit 2026-10-03 18:16:36 +08:00
Merge branch 'master' into fix/548
Project CI / AI game creator shell Rust crates (pull_request) Successful in 3m22s
Details
Project CI / AI game creator shell Rust lane 2/2 (pull_request) Successful in 5m20s
Details
Project CI / Frontend tests (pull_request) Successful in 1m59s
Details
Project CI / AI game creator shell Rust lane 1/2 (pull_request) Successful in 5m42s
Details
Project CI / Native shell tests (pull_request) Successful in 7m24s
Details
Project CI / AI game creator shell web tests (pull_request) Successful in 2m33s
Details
Project CI / Repository checks (pull_request) Failing after 3m17s
Details
Project CI / Backend tests (pull_request) Failing after 4m16s
Details
88569e1b20
lhk229 merged commit 2233f1b7c4 into master 2026-10-03 18:54:13 +08:00
lhk229 deleted branch fix/548 2026-10-03 18:54:13 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
lhk229
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
18250971020 Fiorina (张馨月) HuangJiaJia JenkenB (包仲航) k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#598
Delete Branch "fix/548"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?