GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 14 Pull Requests 3 Actions Packages Projects 3 Releases Wiki Activity

优化错误报告 #286

Merged
kdletters merged 14 commits from style/better-error-report into master 2026-09-07 15:17:21 +08:00
Conversation 5 Commits 14 Files Changed 5
+193 -27
k88936 commented 2026-09-05 19:00:05 +08:00
Member
Copy Link
Copy Source

样式

before:
shotmd-1788605870.jpg
shotmd-1788605755.jpg

after:
shotmd-1788607435.jpg
shotmd-1788608364.jpg

逻辑:
每次打开报告modal会再次查询队列中的错误

样式 before: ![shotmd-1788605870.jpg](/attachments/0470de00-944f-466e-a339-cf9e6cc0b780) ![shotmd-1788605755.jpg](/attachments/3e7be68e-31c5-41ba-9f8b-6dc98ec08868) after: ![shotmd-1788607435.jpg](/attachments/165c878e-5c1c-4517-b7d5-74ce97a1a99b) ![shotmd-1788608364.jpg](/attachments/4dd20baf-879c-4aa8-ab51-bcc588d48dbc) 逻辑: 每次打开报告modal会再次查询队列中的错误 <video src="attachments/6d9d9bd7-5b7b-4a05-a7c3-ca64b6fb77f3" title="2026-09-05 19-46-02.mp4" controls></video>
shotmd-1788608364.jpg
6.5 KiB
2026-09-05 19-46-02.mp4
1.6 MiB
shotmd-1788605755.jpg
7.9 KiB
shotmd-1788605870.jpg
44 KiB
shotmd-1788607435.jpg
39 KiB
k88936 added 3 commits 2026-09-05 19:00:06 +08:00
修复错误报告组件按钮背景样式 bdbdd112de 
恢复错误报告对话框提交按钮渐变背景
恢复错误报告通知面板及操作按钮背景
修复错误报告关闭按钮背景 224f227428 
清除关闭按钮继承的主色渐变背景
修复错误报告弹窗打开时读取错误
Project CI / Frontend tests (pull_request) Successful in 2m30s
Details
Project CI / Repository checks (pull_request) Failing after 14s
Details
Project CI / Backend tests (pull_request) Failing after 14s
Details
Project CI / Native shell tests (pull_request) Successful in 17m28s
Details
8b5bd93356 
报告弹窗打开时重新读取当前进程错误快照

通知仅负责控制弹窗打开状态

补充弹窗快照读取测试并同步技术方案
k88936 self-assigned this 2026-09-05 19:39:51 +08:00
k88936 added this to the 陶泥儿gameAgent project 2026-09-05 19:40:06 +08:00
k88936 added 3 commits 2026-09-05 19:50:00 +08:00
将错误通知样式改为内联 Tailwind d3b087f38d 
按应用更新提示样式还原通知布局和按钮
移除通知标题中的不可靠问题数量
更新错误报告通知文案测试 3652b58ee6 
同步两个通知测试对发现问题文案的断言
调整错误报告默认选择策略
Project CI / Repository checks (pull_request) Has been cancelled
Details
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
53e3472922 
错误报告面板打开时默认选中当前快照中的全部错误事件

同步更新 AGC 错误报告技术方案中的默认选择规则
k88936 added 1 commit 2026-09-05 19:52:13 +08:00
Merge branch 'master' into style/better-error-report
Project CI / Repository checks (pull_request) Successful in 2m52s
Details
Project CI / Frontend tests (pull_request) Successful in 3m14s
Details
Project CI / Backend tests (pull_request) Successful in 6m55s
Details
Project CI / Native shell tests (pull_request) Successful in 20m49s
Details
f2c73ef0cd
kdletters requested changes 2026-09-05 19:55:18 +08:00
Dismissed
kdletters left a comment
Member
Copy Link
Copy Source

审查 head 53e3472922a3b0b4c8f304d179ba356db4b7d41e。发现 2 个明确问题，均已附行内评论。

审查 head 53e3472922a3b0b4c8f304d179ba356db4b7d41e。发现 2 个明确问题，均已附行内评论。
apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx
@@ -54,0 +59,4 @@
);
setEventsReady(true);
})
.catch(() => {
kdletters commented 2026-09-05 19:55:18 +08:00
Member
Copy Link
Copy Source

[P2] 读取待报告事件失败时会丢失用户刚点击查看并报告时看到的事件：ErrorReportNotice.openReport 先清空 notificationEvents，随后这里重新查询；一旦 Tauri snapshot 调用发生瞬时失败，catch 只显示状态并保留空 events，用户无法提交，也没有重试按钮，关闭后通知也不会自动恢复。请在打开时保留并传入原快照作为 fallback，或在失败状态提供重试并恢复通知。

[P2] 读取待报告事件失败时会丢失用户刚点击查看并报告时看到的事件：ErrorReportNotice.openReport 先清空 notificationEvents，随后这里重新查询；一旦 Tauri snapshot 调用发生瞬时失败，catch 只显示状态并保留空 events，用户无法提交，也没有重试按钮，关闭后通知也不会自动恢复。请在打开时保留并传入原快照作为 fallback，或在失败状态提供重试并恢复通知。
k88936 marked this conversation as resolved
apps/ai-game-creator-shell/src/features/runtime-config/RuntimeConfigDialog.tsx Outdated
@@ -1462,5 +1462,5 @@
: 'false'
}
onChange={(event) =>
updateRuntimeAgentLlmConfig(
agent.id,
kdletters commented 2026-09-05 19:55:18 +08:00
Member
Copy Link
Copy Source

[P1] 此配置页永远不会显示编辑器连接字段：allowAdvancedExternalEditorConfig 默认是 false，而当前仓库中三个调用点都没有传入该 prop。因此用户虽然能点开连接与工具，但 Base URL/API Key 表单始终为空，无法配置 editorApi，依赖该配置的画布/素材功能会继续以默认空凭据运行并失败。请在实际需要的调用入口传入明确的 allow 值，或移除这个永远为 false 的门控，并增加 UI 测试覆盖保存 editorApi。

[P1] 此配置页永远不会显示编辑器连接字段：allowAdvancedExternalEditorConfig 默认是 false，而当前仓库中三个调用点都没有传入该 prop。因此用户虽然能点开连接与工具，但 Base URL/API Key 表单始终为空，无法配置 editorApi，依赖该配置的画布/素材功能会继续以默认空凭据运行并失败。请在实际需要的调用入口传入明确的 allow 值，或移除这个永远为 false 的门控，并增加 UI 测试覆盖保存 editorApi。
k88936 marked this conversation as resolved
k88936 added 4 commits 2026-09-05 20:16:21 +08:00
修复错误报告加载失败提示 c49b1ff543 
区分错误事件读取失败与空事件列表

增加错误状态回归测试
整理错误报告事件分支渲染 fc5a970e93 
移除错误报告区域的嵌套三元表达式

保持加载、失败、空列表和事件列表行为不变
补充错误报告读取失败约定 c42b526634 
同步技术方案中的快照读取失败提示
Merge remote-tracking branch 'origin/style/better-error-report' into style/better-error-report
Project CI / Repository checks (pull_request) Has been cancelled
Details
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
3c24015f2e
k88936 added 1 commit 2026-09-05 20:24:29 +08:00
保留错误报告通知快照
Project CI / Repository checks (pull_request) Has been cancelled
Details
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
b2f16c3ee0 
读取最新事件失败时回退到打开通知时的事件快照

增加错误报告通知与对话框回归测试

同步错误报告快照回退技术约定
k88936 added 1 commit 2026-09-05 20:24:44 +08:00
Merge branch 'master' into style/better-error-report
Project CI / Frontend tests (pull_request) Successful in 3m57s
Details
Project CI / Repository checks (pull_request) Successful in 2m4s
Details
Project CI / Backend tests (pull_request) Successful in 7m16s
Details
Project CI / Native shell tests (pull_request) Successful in 18m20s
Details
336cb17d94
k88936 requested review from kdletters 2026-09-05 20:29:26 +08:00
k88936 marked the pull request as ready for review 2026-09-05 20:29:29 +08:00
kdletters approved these changes 2026-09-06 19:40:27 +08:00
kdletters left a comment
Member
Copy Link
Copy Source

审查结论：approve。已检查当前 head 与 master 的差异；未发现新的明确正确性、安全性或回归阻塞。ErrorReportDialog/ErrorReportNotice 定向测试、typecheck、eslint 与构建均通过。补充观察：ErrorReportNotice.tsx:22-46 的异步 loadEvents 在打开报告时仍可能回写通知，导致弹窗打开期间横幅重现或提交后残留；这是 P2 的状态新鲜度问题，建议后续用 requestId 失效/关闭期间抑制并在关闭后刷新。

审查结论：approve。已检查当前 head 与 master 的差异；未发现新的明确正确性、安全性或回归阻塞。ErrorReportDialog/ErrorReportNotice 定向测试、typecheck、eslint 与构建均通过。补充观察：ErrorReportNotice.tsx:22-46 的异步 loadEvents 在打开报告时仍可能回写通知，导致弹窗打开期间横幅重现或提交后残留；这是 P2 的状态新鲜度问题，建议后续用 requestId 失效/关闭期间抑制并在关闭后刷新。
kdletters added 1 commit 2026-09-07 15:17:11 +08:00
Merge branch 'master' into style/better-error-report
Project CI / Native shell tests (pull_request) Successful in 20m41s
Details
Project CI / Repository checks (pull_request) Successful in 2m16s
Details
Project CI / Frontend tests (pull_request) Successful in 2m56s
Details
Project CI / Backend tests (pull_request) Successful in 6m31s
Details
4d264dd2b0
kdletters merged commit 964290c641 into master 2026-09-07 15:17:21 +08:00
kdletters deleted branch style/better-error-report 2026-09-07 15:17:21 +08:00
kdletters commented 2026-09-07 15:34:37 +08:00
Member
Copy Link
Copy Source

审查 head 4d264dd2b01d3bbdfb9c41b39b2db7826362ce0f。

发现 1 个明确问题（P2）：apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx:236 将颜色变量用于 background-image（bg-(image:--platform-button-primary-fill)），而该变量是颜色值，不是合法 image 值，提交按钮可能失去预期主色背景，影响报告提交入口可见性。建议改回 bg-[var(--platform-button-primary-fill)] 或显式使用 background-color。

行内 review API 尝试返回 HTTP 422（[]: jsontext: unexpected EOF），故发布本条总评论。

审查 head 4d264dd2b01d3bbdfb9c41b39b2db7826362ce0f。 发现 1 个明确问题（P2）：`apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx:236` 将颜色变量用于 `background-image`（`bg-(image:--platform-button-primary-fill)`），而该变量是颜色值，不是合法 image 值，提交按钮可能失去预期主色背景，影响报告提交入口可见性。建议改回 `bg-[var(--platform-button-primary-fill)]` 或显式使用 `background-color`。 行内 review API 尝试返回 HTTP 422（`[]: jsontext: unexpected EOF`），故发布本条总评论。
kdletters reviewed 2026-09-07 15:34:37 +08:00
kdletters left a comment
Member
Copy Link
Copy Source

审查 head 4d264dd2b01d3bbdfb9c41b39b2db7826362ce0f。

发现 1 个明确问题（P2）：apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx:236 将颜色变量用于 background-image（bg-(image:--platform-button-primary-fill)），而该变量是颜色值，不是合法 image 值，提交按钮可能失去预期主色背景，影响报告提交入口可见性。建议改回 bg-[var(--platform-button-primary-fill)] 或显式使用 background-color。

行内 review API 尝试返回 HTTP 422（[]: jsontext: unexpected EOF），故发布本条总评论。

审查 head 4d264dd2b01d3bbdfb9c41b39b2db7826362ce0f。 发现 1 个明确问题（P2）：`apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx:236` 将颜色变量用于 `background-image`（`bg-(image:--platform-button-primary-fill)`），而该变量是颜色值，不是合法 image 值，提交按钮可能失去预期主色背景，影响报告提交入口可见性。建议改回 `bg-[var(--platform-button-primary-fill)]` 或显式使用 `background-color`。 行内 review API 尝试返回 HTTP 422（`[]: jsontext: unexpected EOF`），故发布本条总评论。
k88936 commented 2026-09-07 16:03:23 +08:00
Author
Member
Copy Link
Copy Source

审查 head 4d264dd2b01d3bbdfb9c41b39b2db7826362ce0f。

发现 1 个明确问题（P2）：apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx:236 将颜色变量用于 background-image（bg-(image:--platform-button-primary-fill)），而该变量是颜色值，不是合法 image 值，提交按钮可能失去预期主色背景，影响报告提交入口可见性。建议改回 bg-[var(--platform-button-primary-fill)] 或显式使用 background-color。

行内 review API 尝试返回 HTTP 422（[]: jsontext: unexpected EOF），故发布本条总评论。

TL;DR：旧写法把“渐变”误当成普通背景色，浏览器不接受；新写法明确告诉 Tailwind 这是背景图片，因此渐变恢复。

> 审查 head 4d264dd2b01d3bbdfb9c41b39b2db7826362ce0f。 > > 发现 1 个明确问题（P2）：`apps/ai-game-creator-shell/src/components/error-report/ErrorReportDialog.tsx:236` 将颜色变量用于 `background-image`（`bg-(image:--platform-button-primary-fill)`），而该变量是颜色值，不是合法 image 值，提交按钮可能失去预期主色背景，影响报告提交入口可见性。建议改回 `bg-[var(--platform-button-primary-fill)]` 或显式使用 `background-color`。 > > 行内 review API 尝试返回 HTTP 422（`[]: jsontext: unexpected EOF`），故发布本条总评论。 TL;DR：旧写法把“渐变”误当成普通背景色，浏览器不接受；新写法明确告诉 Tailwind 这是背景图片，因此渐变恢复。
Sign in to join this conversation.
Reviewers
No Reviewers
kdletters
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project 陶泥儿gameAgent
Assignees
Clear assignees
HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees k88936
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#286
Delete Branch "style/better-error-report"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?