GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 15 Pull Requests 3 Actions Packages Projects 3 Releases Wiki Activity

修复运行时配置读取时 GameAgent 窗口卡死 #263

Closed
suzmii wants to merge 2 commits from fix/game-agent-config-read-lock into feat/agc-llm-router-official-chain
pull from: fix/game-agent-config-read-lock
merge into: GenarrativeAI:feat/agc-llm-router-official-chain
Conversation 1 Commits 2 Files Changed 4
+118 -20
suzmii commented 2026-09-03 12:05:34 +08:00
Member
Copy Link
Copy Source

变更说明

读取 game-creator.config.json 后，配置读取本身已经完成，但附带的 Codex CLI/app-server 能力诊断会让窗口长时间无响应，用户误以为读取失败。

本 PR：

  • 将配置读取/保存与 LLM 诊断解耦，配置内容先展示并立即恢复操作。
  • 将 check_game_creator_llm_config 改为异步 Tauri command，并把阻塞式 Codex 探测移入 spawn_blocking。
  • 后台刷新诊断结果，并通过请求序号避免过期结果覆盖新状态。
  • 增加回归用例，验证诊断未完成时配置面板仍可操作。
  • 同步更新 AGC 技术方案说明。

验证

  • cargo check --manifest-path apps/ai-game-creator-shell/src-tauri/Cargo.toml 通过。
  • cargo fmt --manifest-path apps/ai-game-creator-shell/src-tauri/Cargo.toml -- --check 通过。
  • ESLint、Prettier、npm run check:encoding、git diff --check 通过。
  • 完整 Rust 测试编译仍受基线已有的 call_agc_read_skill_resource 缺失错误阻断，与本 PR 无关。

Fixes #262

## 变更说明 读取 game-creator.config.json 后，配置读取本身已经完成，但附带的 Codex CLI/app-server 能力诊断会让窗口长时间无响应，用户误以为读取失败。 本 PR： - 将配置读取/保存与 LLM 诊断解耦，配置内容先展示并立即恢复操作。 - 将 check_game_creator_llm_config 改为异步 Tauri command，并把阻塞式 Codex 探测移入 spawn_blocking。 - 后台刷新诊断结果，并通过请求序号避免过期结果覆盖新状态。 - 增加回归用例，验证诊断未完成时配置面板仍可操作。 - 同步更新 AGC 技术方案说明。 ## 验证 - cargo check --manifest-path apps/ai-game-creator-shell/src-tauri/Cargo.toml 通过。 - cargo fmt --manifest-path apps/ai-game-creator-shell/src-tauri/Cargo.toml -- --check 通过。 - ESLint、Prettier、npm run check:encoding、git diff --check 通过。 - 完整 Rust 测试编译仍受基线已有的 call_agc_read_skill_resource 缺失错误阻断，与本 PR 无关。 Fixes #262
suzmii added 1 commit 2026-09-03 12:05:34 +08:00
修复运行时配置读取时窗口卡死
Project CI / Repository checks (pull_request) Failing after 10s
Details
Project CI / Backend tests (pull_request) Failing after 9s
Details
Project CI / Frontend tests (pull_request) Successful in 3m11s
Details
Project CI / Native shell tests (pull_request) Failing after 8m13s
Details
d653a5f5a2 
配置读取与LLM诊断解耦
将LLM能力探测移入阻塞线程池
补充配置面板回归测试与技术方案说明
suzmii added 1 commit 2026-09-03 12:11:04 +08:00
Merge branch 'feat/agc-llm-router-official-chain' into fix/game-agent-config-read-lock
Project CI / Repository checks (pull_request) Successful in 2m17s
Details
Project CI / Frontend tests (pull_request) Successful in 2m48s
Details
Project CI / Backend tests (pull_request) Failing after 3m20s
Details
Project CI / Native shell tests (pull_request) Failing after 5m40s
Details
a6e5a1085e
suzmii closed this pull request 2026-09-03 12:11:19 +08:00
kdletters commented 2026-09-03 12:17:42 +08:00
Member
Copy Link
Copy Source

审查 head a6e5a1085e5ec911c1f967609adc3e4deb1c95c7：配置文件读取/保存已与 LLM 能力诊断解耦，诊断改为 spawn_blocking，前端也有过期结果保护。已在该 head 的独立工作树运行 npm run typecheck（通过）和 npx vitest run apps/ai-game-creator-shell/tests/appSurface.test.ts（387/387 通过）。未发现明确的正确性、回归或安全问题。注意：PR 当前已关闭，Gitea 不允许提交 review，因此本次以总评论记录审查结论。

审查 head `a6e5a1085e5ec911c1f967609adc3e4deb1c95c7`：配置文件读取/保存已与 LLM 能力诊断解耦，诊断改为 `spawn_blocking`，前端也有过期结果保护。已在该 head 的独立工作树运行 `npm run typecheck`（通过）和 `npx vitest run apps/ai-game-creator-shell/tests/appSurface.test.ts`（387/387 通过）。未发现明确的正确性、回归或安全问题。注意：PR 当前已关闭，Gitea 不允许提交 review，因此本次以总评论记录审查结论。
Project CI / Repository checks (pull_request) Successful in 2m17s
Details
Project CI / Frontend tests (pull_request) Successful in 2m48s
Details
Project CI / Backend tests (pull_request) Failing after 3m20s
Details
Project CI / Native shell tests (pull_request) Failing after 5m40s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#263
Delete Branch "fix/game-agent-config-read-lock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?