GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 15 Pull Requests 3 Actions Packages Projects 3 Releases Wiki Activity

AGC支持安装扩展skill、MCP #233

Merged
kdletters merged 25 commits from feat/agc_add_on into master 2026-09-01 20:13:48 +08:00
Conversation 10 Commits 25 Files Changed 31
+4019 -32
lhk229 commented 2026-08-31 19:39:01 +08:00
Owner
Copy Link
Copy Source
No description provided.
lhk229 added 3 commits 2026-08-31 19:39:01 +08:00
完善 DirectProject 客户端扩展导入方案 8bae66108a 
新增客户端 Skill 与 MCP 扩展导入技术方案。

记录独立扩展拆分、统一原生命名、默认启用和 Plugin 边界。

同步文档总览、文档地图和长期决策记录。
完成 DirectProject 扩展导入阶段零 bd812093f0 
补充阶段零输入分类、拆分和命名契约。

新增 Skill、MCP、Plugin、混合来源和未知文件样例。

记录阶段零的验证基线。
完成 DirectProject 扩展导入阶段一
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
Project CI / Repository checks (pull_request) Has been cancelled
Details
edf6e19b38 
新增客户端扩展来源存储和 Skill/MCP 结构发现。

接入独立扩展列表、默认启用、重命名、删除和导入入口。

补充阶段一定向测试并更新实施方案状态。
lhk229 marked the pull request as work in progress 2026-08-31 19:39:21 +08:00
lhk229 added 1 commit 2026-08-31 19:39:27 +08:00
Merge branch 'master' into feat/agc_add_on
Project CI / Repository checks (pull_request) Successful in 2m29s
Details
Project CI / Frontend tests (pull_request) Successful in 3m16s
Details
Project CI / Backend tests (pull_request) Successful in 6m20s
Details
Project CI / Native shell tests (pull_request) Successful in 15m56s
Details
92c56cb76f
lhk229 added 3 commits 2026-08-31 21:41:11 +08:00
完成 DirectProject 扩展导入阶段二 25ccd582ec 
接入客户端已启用 Skill 的隔离运行时副本

将重命名同步到运行时 frontmatter 并保留原始来源

把客户端 Skill 集合纳入 app-server 连接池指纹

补充 Skill 运行时复制和指纹定向测试

更新 DirectProject 扩展阶段文档状态
完成 DirectProject 扩展导入阶段三 b6700cec02 
接入客户端已启用 MCP 的隔离原生配置

保留 agc_tools 并隔离第三方 MCP 配置与启动失败

支持 STDIO 和 HTTP 标准字段及来源相对工作目录

将 MCP 集合纳入 app-server 连接池指纹

补充 Plugin MCP 样例、定向测试和现行文档
合并最新 master 到扩展分支
Project CI / Repository checks (pull_request) Successful in 3m11s
Details
Project CI / Frontend tests (pull_request) Successful in 3m26s
Details
Project CI / Backend tests (pull_request) Successful in 6m12s
Details
Project CI / Native shell tests (pull_request) Successful in 16m34s
Details
6a091afc3b 
合并 Direct 回合附件路径映射与行为审计实现

保留客户端 Skill 与 MCP 扩展方案文档入口

同步文档总览和项目记忆索引
lhk229 added 1 commit 2026-09-01 13:02:33 +08:00
修复 DirectProject 首回合 MCP 就绪竞态
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
Project CI / Repository checks (pull_request) Has been cancelled
Details
7731b3280f 
增加 DirectProject MCP 首轮可选启动等待配置

在首次 turn/start 前等待已启用第三方 MCP 的 app-server 状态

保留失败和取消 MCP 的非阻塞处理

同步 DirectProject MCP 扩展技术方案与系统提示行为

补充启动参数和隔离配置断言
lhk229 added 1 commit 2026-09-01 13:03:32 +08:00
Merge branch 'master' into feat/agc_add_on
Project CI / Repository checks (pull_request) Successful in 3m50s
Details
Project CI / Frontend tests (pull_request) Successful in 4m47s
Details
Project CI / Backend tests (pull_request) Successful in 7m39s
Details
Project CI / Native shell tests (pull_request) Successful in 16m8s
Details
c039c4ebaf
kdletters requested changes 2026-09-01 13:29:09 +08:00
Dismissed
kdletters left a comment
Member
Copy Link
Copy Source

审查结论：请求修改。发现 1 个会使扩展禁用/删除失效的明确问题，详见行内评论。

审查结论：请求修改。发现 1 个会使扩展禁用/删除失效的明确问题，详见行内评论。
apps/ai-game-creator-shell/src-tauri/src/client_extensions.rs Outdated
@@ -0,0 +889,4 @@
) -> Result<Option<PathBuf>, String> {
let root = extensions_root()?;
let index = read_index(&root)?;
let client_skill_root = isolated_os_home.join(".agents").join("client-skills");
kdletters commented 2026-09-01 13:29:09 +08:00
Member
Copy Link
Copy Source

[PR #233][head c039c4ebaf] 禁用或删除 Skill 后，运行时目录不会清理旧内容。prepare_enabled_client_skill_root 每次只 create_dir_all(client_skill_root) 并向其中复制当前启用项，但没有删除目录中上一次运行留下的 Skill；当仍有任意其他 Skill 启用时，旧的已禁用/已删除 Skill 会继续位于 client-skills extraRoot 下，并被 Codex 发现和执行。这会使用户的禁用操作失效，并可能继续暴露已移除扩展的提示词/工具。建议在构建运行时目录前清空并重建 client_skill_root（或按稳定来源 ID 精确删除不再启用的子目录），并增加“启用 A、准备运行时目录、禁用/删除 A、再次准备后 A 不存在”的回归测试。

[PR #233][head c039c4ebafa74605704c530bf67a7270ca6a7be6] 禁用或删除 Skill 后，运行时目录不会清理旧内容。`prepare_enabled_client_skill_root` 每次只 `create_dir_all(client_skill_root)` 并向其中复制当前启用项，但没有删除目录中上一次运行留下的 Skill；当仍有任意其他 Skill 启用时，旧的已禁用/已删除 Skill 会继续位于 `client-skills` extraRoot 下，并被 Codex 发现和执行。这会使用户的禁用操作失效，并可能继续暴露已移除扩展的提示词/工具。建议在构建运行时目录前清空并重建 `client_skill_root`（或按稳定来源 ID 精确删除不再启用的子目录），并增加“启用 A、准备运行时目录、禁用/删除 A、再次准备后 A 不存在”的回归测试。
lhk229 commented 2026-09-01 14:05:07 +08:00
Author
Owner
Copy Link
Copy Source

这个评论指出的“运行时 Skill 目录只追加、不清理”问题是成立的；但“上一次运行的旧 Skill 会在正常重启后继续被当前 Codex 发现和执行”需要限定为复用同一个 isolated_os_home 的场景。当前 app-server 每次会从新的临时目录创建隔离 HOME，且启用 Skill fingerprint 变化会切换连接池 key，因此正常重启通常不会复用旧目录。
不过，prepare_enabled_client_skill_root 本身不应依赖这个生命周期细节。现在已将它改为当前启用 Skill 集合的完整投影：每次准备时先清理 client-skills，再重新复制当前有效项。这样可以同时解决禁用、删除、重命名以及源文件变化后的旧内容残留。没有启用 Skill 时也会清理目录并返回 None。

这个评论指出的“运行时 Skill 目录只追加、不清理”问题是成立的；但“上一次运行的旧 Skill 会在正常重启后继续被当前 Codex 发现和执行”需要限定为复用同一个 isolated_os_home 的场景。当前 app-server 每次会从新的临时目录创建隔离 HOME，且启用 Skill fingerprint 变化会切换连接池 key，因此正常重启通常不会复用旧目录。 不过，prepare_enabled_client_skill_root 本身不应依赖这个生命周期细节。现在已将它改为当前启用 Skill 集合的完整投影：每次准备时先清理 client-skills，再重新复制当前有效项。这样可以同时解决禁用、删除、重命名以及源文件变化后的旧内容残留。没有启用 Skill 时也会清理目录并返回 None。
lhk229 marked this conversation as resolved
lhk229 added 1 commit 2026-09-01 13:49:57 +08:00
记录DirectProject客户端Skill自然语言触发能力缺口
Project CI / Native shell tests (pull_request) Has been cancelled
Details
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Repository checks (pull_request) Has been cancelled
Details
fc82f1d3f2 
新增当前AGC Skill导入、注入和显式使用方式说明

记录普通自然语言触发缺口与可复现测试步骤

整理Codex客户端分层和候选修复方向
lhk229 added 1 commit 2026-09-01 14:06:26 +08:00
修复客户端 Skill 运行时目录残留
Project CI / Frontend tests (pull_request) Successful in 4m34s
Details
Project CI / Repository checks (pull_request) Successful in 4m57s
Details
Project CI / Backend tests (pull_request) Successful in 7m39s
Details
Project CI / Native shell tests (pull_request) Successful in 15m57s
Details
745416a83a 
每次准备时重建当前启用 Skill 的隔离运行时目录

补充禁用、重命名和全部禁用后的残留清理测试

更新 DirectProject Skill 运行时投影约定文档
lhk229 marked the pull request as ready for review 2026-09-01 14:06:29 +08:00
lhk229 requested review from kdletters 2026-09-01 14:19:01 +08:00
lhk229 marked the pull request as work in progress 2026-09-01 14:30:14 +08:00
kdletters marked the pull request as ready for review 2026-09-01 15:20:49 +08:00
kdletters added 1 commit 2026-09-01 15:20:53 +08:00
Merge branch 'master' into feat/agc_add_on
Project CI / Frontend tests (pull_request) Successful in 4m35s
Details
Project CI / Repository checks (pull_request) Successful in 5m5s
Details
Project CI / Backend tests (pull_request) Successful in 7m44s
Details
Project CI / Native shell tests (pull_request) Successful in 16m42s
Details
8b6e289a18
lhk229 marked the pull request as work in progress 2026-09-01 15:23:07 +08:00
lhk229 added 1 commit 2026-09-01 15:36:00 +08:00
修复客户端扩展索引并发竞态
Project CI / Repository checks (pull_request) Successful in 4m7s
Details
Project CI / Frontend tests (pull_request) Successful in 4m9s
Details
Project CI / Backend tests (pull_request) Successful in 8m9s
Details
Project CI / Native shell tests (pull_request) Successful in 16m4s
Details
bb0854ec5b 
串行化扩展索引的读改写操作，避免并发更新丢失

使用扩展项 ID 记录 MCP 启动状态并隔离旧连接回调

将扩展项和来源身份纳入 MCP 连接池指纹

补充并发、旧状态回调和身份指纹回归测试

同步 DirectProject 客户端扩展技术方案
lhk229 added 2 commits 2026-09-01 15:49:24 +08:00
修复客户端 Skill 名称大小写冲突 4561458fb5 
Skill 导入和重命名按 ASCII 大小写不敏感规则分配名称

保留 MCP 名称原有大小写敏感语义

补充 Foo、foo、FOO 回归测试

同步更新 DirectProject 扩展命名方案
修正DirectProject扩展导入DTO示例
Project CI / Repository checks (pull_request) Successful in 4m9s
Details
Project CI / Frontend tests (pull_request) Successful in 4m39s
Details
Project CI / Backend tests (pull_request) Successful in 6m44s
Details
Project CI / Native shell tests (pull_request) Successful in 16m3s
Details
a0c72faa27 
更新导入结果为实际 camelCase 字段与完整扩展项结构

明确未知内容通过 imported 中的 extensionType=unknown 项返回
lhk229 added 2 commits 2026-09-01 16:19:31 +08:00
修复首次MCP就绪等待丢失唤醒 aed1525c1b 
调整 DirectProject MCP readiness gate 的通知注册顺序

抽取 MCP 启动终态判断并增加 missed wakeup 回归测试

同步客户端扩展技术方案中的等待契约
接入DirectProject扩展fixture回归测试
Project CI / Repository checks (pull_request) Successful in 4m15s
Details
Project CI / Frontend tests (pull_request) Successful in 4m35s
Details
Project CI / Backend tests (pull_request) Successful in 8m6s
Details
Project CI / Native shell tests (pull_request) Successful in 18m37s
Details
c250764b59 
读取 expected-imports.json 校验全部导入分类样例

覆盖重复导入、未知项、重命名、启停与删除生命周期
kdletters commented 2026-09-01 16:27:31 +08:00
Member
Copy Link
Copy Source

审查 head sha：c250764b596824965ee1492aa42f6675bf68f109

结论：请求修改。明确问题：导入 .zip 的 extract_zip 未限制条目数、单项解压大小或累计解压大小，直接逐项创建文件并复制。压缩炸弹/恶意扩展可在导入时耗尽磁盘，造成客户端或同机服务不可用。建议限制压缩包条目数、单项与累计解压字节数，超限清理 staging 并失败；同时限制异常压缩比。问题位置：apps/ai-game-creator-shell/src-tauri/src/client_extensions.rs 新文件第 2566 行附近。

审查 head sha：c250764b596824965ee1492aa42f6675bf68f109 结论：请求修改。明确问题：导入 `.zip` 的 `extract_zip` 未限制条目数、单项解压大小或累计解压大小，直接逐项创建文件并复制。压缩炸弹/恶意扩展可在导入时耗尽磁盘，造成客户端或同机服务不可用。建议限制压缩包条目数、单项与累计解压字节数，超限清理 staging 并失败；同时限制异常压缩比。问题位置：`apps/ai-game-creator-shell/src-tauri/src/client_extensions.rs` 新文件第 2566 行附近。
kdletters requested changes 2026-09-01 16:27:45 +08:00
Dismissed
kdletters left a comment
Member
Copy Link
Copy Source

审查 head sha：c250764b596824965ee1492aa42f6675bf68f109。结论：请求修改；详见 PR 总评论 ID 2846（行内评论 API 返回 500，已回退总评论）。

审查 head sha：c250764b596824965ee1492aa42f6675bf68f109。结论：请求修改；详见 PR 总评论 ID 2846（行内评论 API 返回 500，已回退总评论）。
lhk229 added 2 commits 2026-09-01 16:49:59 +08:00
修复扩展列表初次加载空态 fa9d4579c8 
增加客户端扩展列表 loading、ready 和 error 状态

初次异步读取期间显示加载提示，读取成功为空时才显示空列表提示

补充运行时设置界面回归测试并同步技术方案
修复客户端MCP连接状态竞态
Project CI / Repository checks (pull_request) Has been cancelled
Details
Project CI / Frontend tests (pull_request) Has been cancelled
Details
Project CI / Backend tests (pull_request) Has been cancelled
Details
Project CI / Native shell tests (pull_request) Has been cancelled
Details
7be000b204 
为每个 DirectProject MCP 连接分配运行时 token

按扩展项与连接 token 校验启动状态回写

扩展启停、重命名和删除时失效旧连接 owner

补充旧连接迟到状态回归测试
lhk229 commented 2026-09-01 16:50:50 +08:00
Author
Owner
Copy Link
Copy Source

产品决策：校验大小的功能明确不做

产品决策：校验大小的功能明确不做
lhk229 added 1 commit 2026-09-01 16:53:19 +08:00
Merge remote-tracking branch 'origin/master' into feat/agc_add_on
Project CI / Repository checks (pull_request) Failing after 2m51s
Details
Project CI / Native shell tests (pull_request) Failing after 5m0s
Details
Project CI / Frontend tests (pull_request) Successful in 5m6s
Details
Project CI / Backend tests (pull_request) Successful in 7m39s
Details
7b87ed052b 
# Conflicts:
#	docs/technical/【技术方案】AI游戏创作智能体App实施计划-2026-06-24.md
lhk229 marked the pull request as ready for review 2026-09-01 16:53:42 +08:00
kdletters requested changes 2026-09-01 17:00:23 +08:00
kdletters left a comment
Member
Copy Link
Copy Source

审查 head sha：7b87ed052b17d71a6793c86c829242db98ef2f68

结论：请求修改。发现明确的安全/可用性问题：导入 zip 时未限制条目数、单项解压大小或累计解压大小，恶意压缩包可能耗尽磁盘。详见随后发布的 PR 总评论。

审查 head sha：7b87ed052b17d71a6793c86c829242db98ef2f68 结论：请求修改。发现明确的安全/可用性问题：导入 zip 时未限制条目数、单项解压大小或累计解压大小，恶意压缩包可能耗尽磁盘。详见随后发布的 PR 总评论。
kdletters commented 2026-09-01 17:00:23 +08:00
Member
Copy Link
Copy Source

审查 head sha：7b87ed052b17d71a6793c86c829242db98ef2f68

明确问题（请求修改）：apps/ai-game-creator-shell/src-tauri/src/client_extensions.rs:351 的 extract_zip 未限制 zip 条目数、单个解压文件大小或累计解压大小，直接逐项创建文件并复制；即使最终只识别为 unknown 扩展，也会先完成解压。恶意压缩包/压缩炸弹可在用户导入时耗尽磁盘，导致客户端或同机服务不可用。建议增加条目数、单项/累计解压字节数及异常压缩比限制，超限时清理 staging 并返回错误。行内评论 API 返回 422（jsontext: unexpected EOF），因此以本总评论回退。

审查 head sha：7b87ed052b17d71a6793c86c829242db98ef2f68 明确问题（请求修改）：`apps/ai-game-creator-shell/src-tauri/src/client_extensions.rs:351` 的 `extract_zip` 未限制 zip 条目数、单个解压文件大小或累计解压大小，直接逐项创建文件并复制；即使最终只识别为 unknown 扩展，也会先完成解压。恶意压缩包/压缩炸弹可在用户导入时耗尽磁盘，导致客户端或同机服务不可用。建议增加条目数、单项/累计解压字节数及异常压缩比限制，超限时清理 staging 并返回错误。行内评论 API 返回 422（`jsontext: unexpected EOF`），因此以本总评论回退。
lhk229 added 2 commits 2026-09-01 17:11:04 +08:00
修复客户端 Rust 格式检查失败 fed177aea1 
格式化客户端扩展实现以通过 cargo fmt 检查

同步整理客户端扩展模块在 main.rs 中的声明与导入顺序
Merge remote-tracking branch 'origin/master' into feat/agc_add_on
Project CI / Repository checks (pull_request) Successful in 3m13s
Details
Project CI / Frontend tests (pull_request) Successful in 3m49s
Details
Project CI / Backend tests (pull_request) Successful in 8m10s
Details
Project CI / Native shell tests (pull_request) Failing after 18m31s
Details
67fb78d852
kdletters added 1 commit 2026-09-01 17:42:30 +08:00
Merge branch 'master' into feat/agc_add_on
Project CI / Frontend tests (pull_request) Successful in 5m6s
Details
Project CI / Backend tests (pull_request) Successful in 7m20s
Details
Project CI / Repository checks (pull_request) Successful in 2m59s
Details
Project CI / Native shell tests (pull_request) Failing after 16m37s
Details
e0dee7736c
kdletters commented 2026-09-01 17:42:51 +08:00
Member
Copy Link
Copy Source

格式化一下rust代码

格式化一下rust代码
lhk229 added 1 commit 2026-09-01 18:40:59 +08:00
Merge branch 'master' into feat/agc_add_on
Project CI / Repository checks (pull_request) Successful in 2m37s
Details
Project CI / Backend tests (pull_request) Successful in 6m9s
Details
Project CI / Frontend tests (pull_request) Successful in 3m13s
Details
Project CI / Native shell tests (pull_request) Failing after 17m15s
Details
9f06f8be7b
kdletters commented 2026-09-01 18:44:29 +08:00
Member
Copy Link
Copy Source

审查 head sha：9f06f8be7b2a1625d64787d273409d6ce9e0741d。

结论：未发现明确问题。已检查 base a187d78a1c 到当前 head 的代码差异、相关 Rust/前端代码、扩展导入与 MCP/Skill 生命周期测试；cargo check --locked 通过；cargo test --locked client_extensions -- --nocapture 命令退出码为 0，但当前测试目标未匹配到测试（0 tests executed）。

审查 head sha：9f06f8be7b2a1625d64787d273409d6ce9e0741d。 结论：未发现明确问题。已检查 base a187d78a1ca1d1d0c8acc46fc80203f21d2397a9 到当前 head 的代码差异、相关 Rust/前端代码、扩展导入与 MCP/Skill 生命周期测试；cargo check --locked 通过；cargo test --locked client_extensions -- --nocapture 命令退出码为 0，但当前测试目标未匹配到测试（0 tests executed）。
kdletters approved these changes 2026-09-01 18:44:38 +08:00
Dismissed
kdletters left a comment
Member
Copy Link
Copy Source

审查 head sha：9f06f8be7b2a1625d64787d273409d6ce9e0741d。结论：未发现明确问题。

审查 head sha：9f06f8be7b2a1625d64787d273409d6ce9e0741d。结论：未发现明确问题。
kdletters approved these changes 2026-09-01 18:44:58 +08:00
Dismissed
kdletters left a comment
Member
Copy Link
Copy Source

审查 head sha：9f06f8be7b2a1625d64787d273409dce9e0741d。

审查 head sha：9f06f8be7b2a1625d64787d273409dce9e0741d。
lhk229 added 1 commit 2026-09-01 19:26:44 +08:00
合并最新 master
Project CI / Repository checks (pull_request) Failing after 1m49s
Details
Project CI / Backend tests (pull_request) Successful in 7m53s
Details
Project CI / Native shell tests (pull_request) Failing after 15m6s
Details
Project CI / Frontend tests (pull_request) Successful in 3m31s
Details
3d643e1527 
合并 origin/master 到 feat/agc_add_on。

保留客户端 Skill 与 MCP 扩展管理页面及初次加载状态。

合并 AGC 客户端更新检查与下载能力。

补齐文档索引中的扩展导入方案和客户端更新方案。
lhk229 dismissed kdletters's review 2026-09-01 19:26:44 +08:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

lhk229 requested review from kdletters 2026-09-01 19:52:03 +08:00
kdletters merged commit b14e42d9bb into master 2026-09-01 20:13:48 +08:00
kdletters deleted branch feat/agc_add_on 2026-09-01 20:13:49 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
kdletters
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#233
Delete Branch "feat/agc_add_on"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?