GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 21 Pull Requests 4 Actions Packages Projects 3 Releases Wiki Activity

调整画布拖拽交互仅保留鼠标中键 #88

Merged
kdletters merged 7 commits from fix/middle-button-canvas-pan into master 2026-07-20 14:49:00 +08:00
Conversation 3 Commits 7 Files Changed 4
+333 -37
Yunine commented 2026-07-17 17:33:33 +08:00
Contributor
Copy Link
Copy Source

移除鼠标右键拖拽画布的交互处理

保留鼠标中键拖拽画布功能

同步更新相关交互测试

移除鼠标右键拖拽画布的交互处理 保留鼠标中键拖拽画布功能 同步更新相关交互测试
Yunine added 1 commit 2026-07-17 17:33:33 +08:00
调整画布拖拽交互仅保留鼠标中键 c5be50698e 
移除鼠标右键拖拽画布的交互处理

保留鼠标中键拖拽画布功能

同步更新相关交互测试
kdletters commented 2026-07-17 17:57:08 +08:00
Member
Copy Link
Copy Source

功能/契约风险
[P1] 新增测试无法运行。 测试文件第 3 行 (line 3) 未导入 fireEvent，导致定向测试失败、npm run typecheck 报 3 个 TS2304。

[P2] 右键平移未完全移除。 图层处理器 (line 278) 和 生成框处理器 (line 484) 在抓手或 Space 临时抓手模式下，仍会让右键进入 startPan。新增测试只覆盖默认选择模式下的空白区域。

仓库规范符合度
[P2] 格式门禁未通过。 新增测试 (line 931) 有三处行尾空格；Prettier 检查两个改动文件均失败。

功能/契约风险 [P1] 新增测试无法运行。 [测试文件第 3 行 (line 3)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.test.tsx:3) 未导入 fireEvent，导致定向测试失败、npm run typecheck 报 3 个 TS2304。 [P2] 右键平移未完全移除。 [图层处理器 (line 278)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.ts:278) 和 [生成框处理器 (line 484)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.ts:484) 在抓手或 Space 临时抓手模式下，仍会让右键进入 startPan。新增测试只覆盖默认选择模式下的空白区域。 仓库规范符合度 [P2] 格式门禁未通过。 [新增测试 (line 931)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.test.tsx:931) 有三处行尾空格；Prettier 检查两个改动文件均失败。
Yunine added 1 commit 2026-07-17 20:35:37 +08:00
修复右键按下时不再触发画布平移 0b037f46e9
Yunine added 1 commit 2026-07-17 20:38:09 +08:00
修复测试文件 e7279166c9
kdletters commented 2026-07-17 21:01:31 +08:00
Member
Copy Link
Copy Source
  1. 右键 pointerdown 被 preventDefault()，破坏现有右键菜单契约。 rejectRightButtonInteraction (line 217) 会取消右键事件。现有 ImageCanvasEditorView 测试明确要求右键按下不被取消，现在该测试失败；这可能影响浏览器后续触发右键菜单。应该在右键处理函数中进行中断，而不是直接阻止右键事件。
  2. 上一轮的 fireEvent 问题仍未修复。 测试文件第 3 行 (line 3) 仍未导入 fireEvent，测试失败且类型检查报 3 个 TS2304。最新“修复测试文件”提交只格式化了另一个测试文件。
  3. 新 helper 遗漏 Hook 依赖。 画布 handler 依赖数组 (line 284) 以及第 409、547 行都缺少 rejectRightButtonInteraction，ESLint 因 3 个 exhaustive-deps warning 失败。
  4. 格式门禁仍失败。 新增测试 (line 931) 仍有三处行尾空格，Prettier 和 git diff --check 均未通过。
1. 右键 pointerdown 被 preventDefault()，破坏现有右键菜单契约。 [rejectRightButtonInteraction (line 217)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.ts:217) 会取消右键事件。现有 ImageCanvasEditorView 测试明确要求右键按下不被取消，现在该测试失败；这可能影响浏览器后续触发右键菜单。应该在右键处理函数中进行中断，而不是直接阻止右键事件。 2. 上一轮的 fireEvent 问题仍未修复。 [测试文件第 3 行 (line 3)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.test.tsx:3) 仍未导入 fireEvent，测试失败且类型检查报 3 个 TS2304。最新“修复测试文件”提交只格式化了另一个测试文件。 3. 新 helper 遗漏 Hook 依赖。 [画布 handler 依赖数组 (line 284)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.ts:284) 以及第 409、547 行都缺少 rejectRightButtonInteraction，ESLint 因 3 个 exhaustive-deps warning 失败。 4. 格式门禁仍失败。 [新增测试 (line 931)](/home/dsk/.codex/worktrees/7b48/Genarrative/src/components/image-editor/useImageCanvasStageInteractions.test.tsx:931) 仍有三处行尾空格，Prettier 和 git diff --check 均未通过。
Yunine added 1 commit 2026-07-19 18:56:42 +08:00
补充画布测试交互事件导入 46db6055fa
Yunine added 1 commit 2026-07-20 10:25:17 +08:00
Merge branch 'master' into fix/middle-button-canvas-pan 96dfb6c7d3
Yunine added 1 commit 2026-07-20 13:38:55 +08:00
修复右键图层时 pointerdown 被取消导致右键菜单无法打开的问题 68b51aba22
kdletters approved these changes 2026-07-20 14:48:46 +08:00
kdletters added 1 commit 2026-07-20 14:48:50 +08:00
Merge branch 'master' into fix/middle-button-canvas-pan f107d6e461
kdletters merged commit a5669602c0 into master 2026-07-20 14:49:00 +08:00
kdletters deleted branch fix/middle-button-canvas-pan 2026-07-20 14:49:00 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
kdletters
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#88
Delete Branch "fix/middle-button-canvas-pan"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?