GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 21 Pull Requests 4 Actions Packages Projects 3 Releases Wiki Activity

抽取配色css #79

Merged
kdletters merged 5 commits from extract-color-schema into master 2026-07-14 17:01:40 +08:00
Conversation 5 Commits 5 Files Changed 6
+621 -540
k88936 commented 2026-07-14 11:53:32 +08:00
Member
Copy Link
Copy Source
No description provided.
k88936 added 1 commit 2026-07-14 11:53:32 +08:00
extract color schema 12ddaba231
kdletters commented 2026-07-14 12:42:32 +08:00
Member
Copy Link
Copy Source

[P1] 测试与文档引用了不存在的文件。

theme.test.ts:8 和

index.test.ts:12 读取 platform-theme.css，实际文件和运行时导入是 theme.css。定向测试结果为 2 failed / 13 passed，均为 ENOENT。两份文档也写错了同一路径，需要统一命名。
• [P2] 抽取改变了字体层叠顺序。

index.css:3 将

theme.css:1 的全局 !important 字体规则提前，导致绑定手机号页“陶泥儿”标题从 Inter 变成 Noto Serif SC。Chromium computed-style 已确认。若这里只想抽取配色，应保留字体规则原有层叠位置；若接受视觉变化，需要明确记录并补视觉契约。

[P1] 测试与文档引用了不存在的文件。  theme.test.ts:8 和  index.test.ts:12 读取 platform-theme.css，实际文件和运行时导入是 theme.css。定向测试结果为 2 failed / 13 passed，均为 ENOENT。两份文档也写错了同一路径，需要统一命名。 • [P2] 抽取改变了字体层叠顺序。  index.css:3 将  theme.css:1 的全局 !important 字体规则提前，导致绑定手机号页“陶泥儿”标题从 Inter 变成 Noto Serif SC。Chromium computed-style 已确认。若这里只想抽取配色，应保留字体规则原有层叠位置；若接受视觉变化，需要明确记录并补视觉契约。
kdletters requested review from kdletters 2026-07-14 13:09:53 +08:00
kdletters commented 2026-07-14 13:16:54 +08:00
Member
Copy Link
Copy Source

[P1] 测试与文档引用了不存在的文件。 theme.test.ts:8 和 index.test.ts:12 读取 platform-theme.css，实际文件和运行时导入是 theme.css。定向测试结果为 2 failed / 13 passed，均为 ENOENT。两份文档也写错了同一路径，需要统一命名。
[P2] 抽取改变了字体层叠顺序。 index.css:3 将 theme.css:1 的全局 !important 字体规则提前，导致绑定手机号页“陶泥儿”标题从 Inter 变成 Noto Serif SC。Chromium computed-style 已确认。若这里只想抽取配色，应保留字体规则原有层叠位置；若接受视觉变化，需要明确记录并补视觉契约。

[P1] 测试与文档引用了不存在的文件。 [theme.test.ts:8](https://git.genarrative.world/git/GenarrativeAI/Genarrative/src/commit/12ddaba23140915ef9c2661eda331793aa727ebe/packages/shared/src/theme.test.ts#L8) 和 [index.test.ts:12](https://git.genarrative.world/git/GenarrativeAI/Genarrative/src/commit/12ddaba23140915ef9c2661eda331793aa727ebe/src/index.test.ts#L12) 读取 platform-theme.css，实际文件和运行时导入是 theme.css。定向测试结果为 2 failed / 13 passed，均为 ENOENT。两份文档也写错了同一路径，需要统一命名。 [P2] 抽取改变了字体层叠顺序。 [index.css:3](https://git.genarrative.world/git/GenarrativeAI/Genarrative/src/commit/12ddaba23140915ef9c2661eda331793aa727ebe/src/index.css#L3) 将 [theme.css:1](https://git.genarrative.world/git/GenarrativeAI/Genarrative/src/commit/12ddaba23140915ef9c2661eda331793aa727ebe/packages/shared/src/theme.css#L1) 的全局 !important 字体规则提前，导致绑定手机号页“陶泥儿”标题从 Inter 变成 Noto Serif SC。Chromium computed-style 已确认。若这里只想抽取配色，应保留字体规则原有层叠位置；若接受视觉变化，需要明确记录并补视觉契约。
k88936 added 3 commits 2026-07-14 16:27:37 +08:00
update theme path references in tests 9ecf0a2d91
Merge remote-tracking branch 'refs/remotes/origin/master' into extract-color-schema a20b1bf372
specially treat font to make sure it will not override 40a92c0a7a
k88936 commented 2026-07-14 16:28:52 +08:00
Author
Member
Copy Link
Copy Source

fixed 1 2

fixed 1 2
kdletters approved these changes 2026-07-14 17:00:55 +08:00
Dismissed
kdletters added 1 commit 2026-07-14 17:01:02 +08:00
Merge branch 'master' into extract-color-schema cde26ea66d
kdletters dismissed kdletters's review 2026-07-14 17:01:02 +08:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

kdletters scheduled this pull request to auto merge when all checks succeed 2026-07-14 17:01:28 +08:00
kdletters approved these changes 2026-07-14 17:01:38 +08:00
kdletters merged commit d66b17b855 into master 2026-07-14 17:01:40 +08:00
kdletters deleted branch extract-color-schema 2026-07-14 17:01:40 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
kdletters
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#79
Delete Branch "extract-color-schema"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?