GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 41 Pull Requests 12 Actions Packages Projects 1 Releases Wiki Activity

WIP: 清理 AGC 壳 process_session/project 模块编译 warning（#649） #654

Closed
suzmii wants to merge 0 commits from chore/agc-warnings-session into master
pull from: chore/agc-warnings-session
merge into: GenarrativeAI:master
Conversation 1 Commits - Files Changed -
+56 -6302
suzmii commented 2026-10-06 16:47:47 +08:00
Member
Copy Link
Copy Source

关联

范围（本条 lane：process_session / project）

  • src/process_session*；
  • src/project*；
  • 已授权的 runner/tests.rs 死 import 块。

关键口径

  • G5 agent_db ledger 属「仅测试可达」：按运维文档 line 361-362 的口径（「不以清零告警为由排除已有测试覆盖」「Agent DB 链接安全断言…底层生产实现与共享测试逻辑继续保留」），用 cfg(test) 收敛保留实现，security_tests.rs 68 例零改动。
  • checkpoint 的安全用例只剥离 diff 断言，硬链接 / 符号链接 / 敏感路径断言全部保留。

计数

  • bin：613 → 488（本条 lane 领地 128 → 3）；
  • --all-targets：1034 → 860（本条 lane 领地 183 → 10）；
  • 清除构成：94 项删除 + 31 项 cfg 收敛 + 3 项待协调。

测试

cargo test --features cocos-editor-execute,unity-editor-execute,godot-editor-execute \
  --manifest-path apps/ai-game-creator-shell/src-tauri/Cargo.toml -- <filter>

结果 142 passed / 0 failed（process_session 1、checkpoint 7、agent_db 62、conversation 6、manifest 66）。

覆盖变化

  • process_session：删 30 例（覆盖对象是已整体退役的 ProcessSessionRecord 执行面）；
  • checkpoint：删 3 例（diff 渲染 / 预算 / 二进制标记），链接安全断言未丢。

留成 follow-up 的 6 项（需协调）

  • 依赖 lane D 门控 commands.rs：memory.rs 5 符号、filesystem.rs:247、verification.rs:4 等；
  • 依赖 lane C 合入后 rebase 补删：conversation.rs:1215、manifest.rs:1095、agent_db.rs:4367 等。
## 关联 - Issue #649 ## 范围（本条 lane：`process_session` / `project`） - `src/process_session*`； - `src/project*`； - 已授权的 `runner/tests.rs` 死 import 块。 ## 关键口径 - **G5 `agent_db` ledger 属「仅测试可达」**：按运维文档 line 361-362 的口径（「不以清零告警为由排除已有测试覆盖」「Agent DB 链接安全断言…底层生产实现与共享测试逻辑继续保留」），用 `cfg(test)` **收敛保留实现**，`security_tests.rs` 68 例零改动。 - `checkpoint` 的安全用例只剥离 diff 断言，硬链接 / 符号链接 / 敏感路径断言全部保留。 ## 计数 - bin：**613 → 488**（本条 lane 领地 **128 → 3**）； - `--all-targets`：**1034 → 860**（本条 lane 领地 **183 → 10**）； - 清除构成：94 项删除 + 31 项 `cfg` 收敛 + 3 项待协调。 ## 测试 ```bash cargo test --features cocos-editor-execute,unity-editor-execute,godot-editor-execute \ --manifest-path apps/ai-game-creator-shell/src-tauri/Cargo.toml -- <filter> ``` 结果 **142 passed / 0 failed**（`process_session` 1、`checkpoint` 7、`agent_db` 62、`conversation` 6、`manifest` 66）。 ## 覆盖变化 - `process_session`：删 30 例（覆盖对象是已整体退役的 `ProcessSessionRecord` 执行面）； - `checkpoint`：删 3 例（diff 渲染 / 预算 / 二进制标记），链接安全断言未丢。 ## 留成 follow-up 的 6 项（需协调） - 依赖 lane D 门控 `commands.rs`：`memory.rs` 5 符号、`filesystem.rs:247`、`verification.rs:4` 等； - 依赖 lane C 合入后 rebase 补删：`conversation.rs:1215`、`manifest.rs:1095`、`agent_db.rs:4367` 等。
suzmii added 1 commit 2026-10-06 16:47:47 +08:00
清理 AGC 客户端退役运行时遗留的编译告警（session record / 内容 diff / ledger 写入层）
Project CI / AI game creator shell Rust crates (pull_request) Successful in 5m57s
Details
Project CI / AI game creator shell Rust lane 2/2 (pull_request) Successful in 7m16s
Details
Project CI / AI game creator shell Rust lane 1/2 (pull_request) Successful in 8m0s
Details
Project CI / Frontend tests (pull_request) Successful in 3m31s
Details
Project CI / Backend tests (pull_request) Successful in 7m31s
Details
Project CI / AI game creator shell web tests (pull_request) Successful in 3m21s
Details
Project CI / Native shell tests (pull_request) Successful in 8m27s
Details
Project CI / Repository checks (pull_request) Successful in 6m58s
Details
4e8662e87c 
- process_session：删除退役的 record 模型与 io/persistence/lifecycle 模块及 30 例专属测试，保留 WindowsProcessJob、process_session_bridge 与 Runner 退出用的会话收尾入口。
- project/checkpoint：删除退役的本地项目内容 diff 实现与 3 例专属测试；3 例链接/敏感路径安全用例剥离 diff 断言后保留。
- project/agent_db：ledger 写入/校验层已无生产调用方、仅安全断言使用，27 项按 cfg(test) 收敛保留 68 例覆盖，4 项真死删除。
- project/*：真死条目删除，测试独占条目 cfg(test)，仅生产入口条目按调用方条件 cfg(not(test))；project.rs 丢弃失效 re-export/导入。
- runner/tests.rs：删除已无引用的 crate 导入块。
suzmii commented 2026-10-06 16:58:34 +08:00
Author
Member
Copy Link
Copy Source

内容已并入 #650（单 PR 口径：用户要求不再按模块拆分 PR，避免逐分支功能测试）。分支 chore/agc-warnings-session 保留在远端作为历史，不再单独合并。

内容已并入 #650（单 PR 口径：用户要求不再按模块拆分 PR，避免逐分支功能测试）。分支 `chore/agc-warnings-session` 保留在远端作为历史，不再单独合并。
suzmii closed this pull request 2026-10-06 16:58:35 +08:00
Some checks are pending
Project CI / AI game creator shell Rust crates (pull_request) Successful in 5m57s
Details
Project CI / AI game creator shell Rust lane 2/2 (pull_request) Successful in 7m16s
Details
Project CI / AI game creator shell Rust lane 1/2 (pull_request) Successful in 8m0s
Details
Project CI / Frontend tests (pull_request) Successful in 3m31s
Details
Project CI / Backend tests (pull_request) Successful in 7m31s
Details
Project CI / AI game creator shell web tests (pull_request) Successful in 3m21s
Details
Project CI / Native shell tests (pull_request) Successful in 8m27s
Details
Project CI / Repository checks (pull_request) Successful in 6m58s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
18250971020 Fiorina (张馨月) HuangJiaJia JenkenB (包仲航) k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#654
Delete Branch "chore/agc-warnings-session"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?