退役 DirectProject 工具调用与回合流账本 #560

Merged

k88936 merged 7 commits from refactor/remove-toolcall.jsonl-legacy into master 2026-10-01 16:13:14 +08:00

Conversation 2 Commits 7 Files Changed 18

+365 -2556

k88936 commented 2026-09-30 19:43:45 +08:00

Member

Copy Link

Copy Source

• agent/direct_tool_calls.rs、agent/direct_turn_stream.rs：整体删除

- agent/direct_tool_calls.rs、agent/direct_turn_stream.rs：整体删除

k88936 added 1 commit 2026-09-30 19:43:45 +08:00

退役 DirectProject 工具调用与回合流账本 ... 719db293d2

- agent/direct_tool_calls.rs、agent/direct_turn_stream.rs：整体删除，agent.rs 去掉模块声明与导出
- direct_runtime/mod.rs：删 DirectToolCallCollector、回合流节流器与全部落盘/发射调用点，observer 只回填 update_active_turn
- codex_app_server/mod.rs：删 DirectCodexTurnObservation::ToolCall，AgentMessageSegment 结构体变体简化为元组变体，direct_tool_call_turn_id / direct_tool_call_now_ms 改名
- claude_code_cli.rs：删 tool_use / tool_result 采集分支与 DirectToolCall 构造
- main.rs、runtime_driver/entrypoints.rs：删 GameCreatorDirectTurnUpdateEvent 与 game-creator-direct-turn-update 事件，emit 收缩为 (status, activity)
- thread_manager/wire.rs：新增 direct_now_ms，替代随 direct_tool_calls 删除的时钟函数
- docs：ADR、工具调用卡片技术方案、DirectProject 聊天真相源收敛里程碑与实施计划、pitfalls 旧路径同步到当前状态，decision-log 新增 2026-09-30 退役条目
- 未修（另开）：redact_absolute_path_tokens 的无语境绝对路径扫描仍会误伤 HTML 结束标签与嵌套 JSON 转义
- 验证：cargo test --bin genarrative-ai-game-creator-shell agent::（929 passed / 0 failed / 5 ignored）、npm run check:encoding、npm run check:doc-index、git diff --check

k88936 added 3 commits 2026-10-01 11:50:26 +08:00

修 emit 活动白名单漏项并统一宿主时钟 ... 3611b1e4b9

- runtime_driver/entrypoints.rs：emit 白名单补 host-review / error-feedback——DirectRuntime 实际会传这两个活动，漏项在 debug 构建 panic、release 构建静默丢掉整次进度回填
- runtime_driver/entrypoints.rs：updated_at 改用 direct_now_ms()，删掉内联 Unix-ms 计算，宿主只留一个时钟
- runtime_driver/entrypoints.rs：新增用例钉住 DirectRuntime 传过的全部活动值都在白名单内
- docs：工具调用卡片技术方案「背景与现状」补 superseded 说明，去掉失效的 src/app/types.ts:1090 指针
- 验证：cargo test --bin genarrative-ai-game-creator-shell agent::（930 passed / 0 failed / 5 ignored）、npm run check:encoding、npm run check:doc-index、git diff --check

删除无调用方的 direct_taonier_active_now_millis ... f7aa2af905

- direct_runtime/mod.rs：删除从未被调用的 direct_taonier_active_now_millis（函数体内唯一的 unix_millis 用法随之消失），宿主时钟只留 direct_now_ms
- 验证：cargo test --bin genarrative-ai-game-creator-shell direct_runtime（101 passed / 0 failed）、cargo fmt --check、npm run check:encoding、git diff --check

修掉 dispatch 放行成功分支未使用的 reply 绑定 ... 29c4442ae9

- thread_manager/dispatch.rs：放行成功分支的 `Ok(reply)` 改成 `Ok(_)`——终态文案已改由运行态事件下发，`reply` 不再被消费，留着会触发 unused_variables 警告
- 验证：cargo test --bin genarrative-ai-game-creator-shell thread_manager::（62 passed / 0 failed）、cargo fmt --check、npm run check:encoding、git diff --check

k88936 commented 2026-10-01 11:50:55 +08:00

Author

Member

Copy Link

Copy Source

• 2. thread_manager/dispatch.rs 放行成功分支未使用的 reply 绑定：Ok(reply) → Ok(_)，作为删账本的收尾保留（提交 29c4442ae）。

- [x] 2. `thread_manager/dispatch.rs` 放行成功分支未使用的 `reply` 绑定：`Ok(reply)` → `Ok(_)`，作为删账本的收尾保留（提交 `29c4442ae`）。

k88936 added 1 commit 2026-10-01 11:55:46 +08:00

Merge branch 'master' into refactor/remove-toolcall.jsonl-legacy c0e6396bad

k88936 added 1 commit 2026-10-01 12:58:06 +08:00

Merge branch 'master' into refactor/remove-toolcall.jsonl-legacy cdb2223140

k88936 marked the pull request as ready for review 2026-10-01 15:24:40 +08:00

k88936 added 1 commit 2026-10-01 15:24:51 +08:00

Merge branch 'master' into refactor/remove-toolcall.jsonl-legacy fe62482547

k88936 merged commit 774f95be94 into master 2026-10-01 16:13:14 +08:00

k88936 deleted branch refactor/remove-toolcall.jsonl-legacy 2026-10-01 16:13:15 +08:00

k88936 commented 2026-10-01 16:13:16 +08:00

Author

Member

Copy Link

Copy Source

• 已算出 CI 那个片的精确集合（131 条，与日志 126 passed; 1 failed; 4 ignored 完全对上），本机连跑 4 次复现了 2 次。
• 失败是全局计数器被另一个线程串台：一次是 入队 断言就多 1，一次是 进度 断言多 1 —— 典型的前一个用例遗留后台任务在测试窗口里 emit。
• 现在给 emit_direct_active_turns_changed 加了一段临时 backtrace 打印（AGC_TRACE_ACTIVE_TURN_EMIT 才触发），跑一次拿现场，抓完就 revert。

> - 已算出 CI 那个片的精确集合（131 条，与日志 `126 passed; 1 failed; 4 ignored` 完全对上），本机连跑 4 次复现了 2 次。 > - 失败是**全局计数器被另一个线程串台**：一次是 `入队` 断言就多 1，一次是 `进度` 断言多 1 —— 典型的前一个用例遗留后台任务在测试窗口里 emit。 > - 现在给 `emit_direct_active_turns_changed` 加了一段**临时** backtrace 打印（`AGC_TRACE_ACTIVE_TURN_EMIT` 才触发），跑一次拿现场，抓完就 revert。

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

18250971020 Fiorina (张馨月) HuangJiaJia JenkenB (包仲航) k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#560