Remove Absolute and External Path Restrictions of Design Agent. Fix mac runtime failure #528

Merged

lhk229 merged 7 commits from feat/remove-path-restrictions into master 2026-09-29 17:15:29 +08:00

Conversation 0 Commits 7 Files Changed 9

+333 -79

lhk229 commented 2026-09-29 15:15:17 +08:00

Member

Copy Link

Copy Source

No description provided.

lhk229 added 1 commit 2026-09-29 15:15:49 +08:00

放开策划 Agent 文件工具的绝对路径与工作区外路径 ... 5c601300be

- design_tools 的 list_dir、read_file、write_file、patch_file、delete_path、search_text 接受绝对路径
- 相对路径仍以 design_artifacts 为基准，允许 .. 离开工作区
- 工作区内写入继续走私有文件写入，工作区外按普通文件创建父目录并写入
- 用户工作区浏览和附件导入仍限定在 design_artifacts
- 删除仍不跟随符号链接，也不删除工作区根目录
- 既有测试改为期望 ../secret.md 写入成功
- 同步策划 Agent 方案、decision-log 与 pitfalls
- 提示词未改

lhk229 added 1 commit 2026-09-29 15:28:01 +08:00

去掉策划文件工具说明里的路径硬限制 ... eaaab2e006

- system-prompt 改为要求策划文件放在工作区内并使用相对路径，不再要求所有路径都是相对路径
- read_file、write_file、list_dir、search_text、patch_file、delete_path 的说明去掉「工作目录内」和「path 使用相对路径」
- delete_path 仍说明不能删除工作区根目录，也不能经过链接
- 说明不宣布可以访问绝对路径或工作区外路径
- 同步策划 Agent 方案与 decision-log

lhk229 added 1 commit 2026-09-29 16:11:37 +08:00

修复 Codex 隔离用户目录被系统临时路径符号链接阻断 ... 8b0b6d768c

- 临时目录确认是普通目录后先解析真实路径，再创建 codex-home、workspace 和隔离用户目录
- 祖先符号链接检查不放宽，临时目录内部的符号链接仍然拒绝
- 补充一条符号链接祖先与内部链接测试
- 记录决策与排障说明

lhk229 changed title from WIP: Remove Absolute and External Path Restrictions to WIP: Remove Absolute and External Path Restrictions of Design Agent. Fix mac runtime failure 2026-09-29 16:31:14 +08:00

lhk229 added 1 commit 2026-09-29 16:31:24 +08:00

整理 Codex 私有运行目录测试的格式 ... 90ccb179b9

- 按 rustfmt 收起符号链接祖先测试里的三处 assert

lhk229 marked the pull request as ready for review 2026-09-29 16:34:27 +08:00

lhk229 added 1 commit 2026-09-29 16:39:43 +08:00

修复 Codex 私有运行目录的 Windows UNC 路径转换 ... aaf43ec421

保留 UNC 网络共享根，避免规范化后变成相对路径
补充 UNC、盘符及普通路径回归测试
同步运行目录路径规范与共享决策记录

lhk229 added 1 commit 2026-09-29 16:47:03 +08:00

修复策划工作区删除保护并允许链接路径删除 ... 541fe07a7e

按真实路径保护工作区根目录及其上级目录
允许删除路径经过祖先链接，删除链接本身不影响目标
补充两项删除边界回归测试并同步工具说明与文档

lhk229 added 1 commit 2026-09-29 17:14:53 +08:00

修正策划文件删除逻辑的 Rust 格式 ... d10ab9c77b

按 cargo fmt 整理删除路径解析与回归测试断言的换行

lhk229 merged commit 06f7f145b8 into master 2026-09-29 17:15:29 +08:00

lhk229 deleted branch feat/remove-path-restrictions 2026-09-29 17:15:29 +08:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

18250971020 Fiorina (张馨月) HuangJiaJia JenkenB (包仲航) k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#528