修复 hook 隔离用例把探针自身写入当成被测行为 #523

Merged

suzmii merged 2 commits from fix/git-hooks-index-snapshot into master 2026-09-28 12:03:55 +08:00

Conversation 0 Commits 2 Files Changed 1

+3 -1

suzmii commented 2026-09-27 23:01:47 +08:00

Member

Copy Link

Copy Source

问题

npm run check:repository-ci 在 scripts/git-hooks.test.mjs:246「hook fixtures do not mutate the calling linked worktree or its index」稳定失败；在干净的 origin/master 独立 worktree 上同样复现，属既有问题。

根因

用例在调用 git status --porcelain 之前读取索引做快照，而 git status 会刷新并重写索引里的 stat 缓存（macOS 与部分 git 版本上字节必然变化），于是断言到的是探针自身的副作用，而不是 hook fixture 的污染。

修复

• 先跑完会写索引的探针，再取索引快照；被测行为（fixture 是否污染调用方）的断言不变。
• 验证：node --test scripts/git-hooks.test.mjs 4/4 通过；bash scripts/check-repository-ci.sh origin/master 退出码 0（此前同一条用例必失败）。

## 问题 `npm run check:repository-ci` 在 `scripts/git-hooks.test.mjs:246`「hook fixtures do not mutate the calling linked worktree or its index」稳定失败；在干净的 `origin/master` 独立 worktree 上同样复现，属既有问题。 ## 根因 用例在调用 `git status --porcelain` **之前**读取索引做快照，而 `git status` 会刷新并重写索引里的 stat 缓存（macOS 与部分 git 版本上字节必然变化），于是断言到的是探针自身的副作用，而不是 hook fixture 的污染。 ## 修复 - 先跑完会写索引的探针，再取索引快照；被测行为（fixture 是否污染调用方）的断言不变。 - 验证：`node --test scripts/git-hooks.test.mjs` 4/4 通过；`bash scripts/check-repository-ci.sh origin/master` 退出码 0（此前同一条用例必失败）。

suzmii added 1 commit 2026-09-27 23:01:47 +08:00

修复 hook 隔离用例把探针自身的索引写入当成被测行为 ... 89a51cfd5b

- git-hooks.test.mjs 的隔离用例改为先跑会写索引的探针（git status 会刷新并重写索引的 stat 缓存），再取索引快照，避免把自身副作用断言成 hook fixture 的污染
- 该用例在 macOS 与部分 git 版本上必然失败（干净 origin/master worktree 上同样复现），修后 scripts/git-hooks.test.mjs 4/4 通过、npm run check:repository-ci 全绿

suzmii added 1 commit 2026-09-28 11:45:11 +08:00

Merge branch 'master' into fix/git-hooks-index-snapshot 053c57974e

suzmii merged commit 8f59c034f5 into master 2026-09-28 12:03:55 +08:00

suzmii deleted branch fix/git-hooks-index-snapshot 2026-09-28 12:03:55 +08:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#523