GenarrativeAI/Genarrative
11
0
Fork 0
Code Issues 15 Pull Requests 3 Actions Packages Projects 3 Releases Wiki Activity

Feat/优化UI编辑器inspector offset编辑部分UI #265

Merged
kdletters merged 16 commits from feat/ui-editor-better-offset-ui into master 2026-09-03 19:36:18 +08:00
Conversation 3 Commits 16 Files Changed 4
+493 -38
k88936 commented 2026-09-03 13:05:08 +08:00
Member
Copy Link
Copy Source

before:
image.png
after:
shotmd-1788414839.jpg
close #267

before: ![image.png](/attachments/e0344964-55c6-4ba1-9191-a79d81f32b2e) after: ![shotmd-1788414839.jpg](/attachments/14c8a723-b2df-48d5-9773-7f576bcef873) close #267
image.png
24 KiB
shotmd-1788414839.jpg
18 KiB
k88936 self-assigned this 2026-09-03 13:05:08 +08:00
k88936 added this to the 陶泥儿gameAgent project 2026-09-03 13:05:08 +08:00
k88936 added 8 commits 2026-09-03 13:05:08 +08:00
补充变换角点偏移编辑器设计合同 c3a4dce3af 
新增四角选择与单组输入交互设计文档

记录 Transform offset 映射、方向键语义与验收边界
重做变换角点偏移编辑器 7aaefbf6c1 
新增四角选择状态与单组 X/Y 偏移输入

让方向键只调整当前选中角并支持 Shift 加速与长按
补充变换角点编辑器交互测试 4883cb1193 
覆盖角点切换、共享 offset 映射和方向键调整

同步文档记录选中角点状态在编辑过程中的保持规则
修复方向键长按定时器清理 bbe7ccfae4 
组件卸载时清理重复触发的延时器和间隔器

避免 Inspector 关闭后继续向已卸载编辑器写入更新
修复方向键点击状态复位 57a1d1d1a1 
长按后的点击处理完成后重置 repeated 标记

确保键盘激活不会被上一次长按状态吞掉
将变换编辑器引用同步移入副作用 a1b93ccffa 
在提交后更新 transform 和选中角点引用

避免渲染阶段写入 ref 造成并发模式副作用
统一只读模式下角点选择器状态 c74bfc4d51 
只读变换编辑器禁用四个角点按钮

保持所有变更入口的一致交互语义
补充方向键组可访问语义
Project CI / Repository checks (pull_request) Failing after 8s
Details
Project CI / Backend tests (pull_request) Failing after 10s
Details
Project CI / Frontend tests (pull_request) Successful in 3m19s
Details
Project CI / Native shell tests (pull_request) Successful in 17m21s
Details
29b24695fb 
为角点方向按钮容器添加 group 角色

让角点方向键 aria-label 能被辅助技术识别
k88936 added 1 commit 2026-09-03 13:57:03 +08:00
调整角点选择器垂直对齐
Project CI / Frontend tests (pull_request) Successful in 3m12s
Details
Project CI / Repository checks (pull_request) Failing after 15s
Details
Project CI / Backend tests (pull_request) Failing after 23s
Details
Project CI / Native shell tests (pull_request) Successful in 18m49s
Details
be35687537 
保持左侧角点控件为紧凑正方形

让角点选择器在右侧位置微调控件中垂直居中

完善位置微调控件布局
k88936 added 1 commit 2026-09-03 13:57:05 +08:00
Merge branch 'master' into feat/ui-editor-better-offset-ui
Project CI / Repository checks (pull_request) Failing after 45s
Details
Project CI / Frontend tests (pull_request) Successful in 3m17s
Details
Project CI / Backend tests (pull_request) Successful in 5m50s
Details
Project CI / Native shell tests (pull_request) Failing after 14m10s
Details
7a66527b5e
kdletters approved these changes 2026-09-03 14:00:46 +08:00
Dismissed
kdletters left a comment
Member
Copy Link
Copy Source

审查 head sha: be35687537

未发现明确问题。已检查本次提交相对 base 025f627297 的 TransformEditor 变更，并执行了相关 TransformEditor 测试（3/3 通过）及 TypeScript 类型检查（通过）。

审查 head sha: be35687537efa2851f1018c6b83cd2f6a975ed6e 未发现明确问题。已检查本次提交相对 base 025f6272970cace6670776375f788776c5e85fc0 的 TransformEditor 变更，并执行了相关 TransformEditor 测试（3/3 通过）及 TypeScript 类型检查（通过）。
k88936 marked the pull request as ready for review 2026-09-03 14:15:12 +08:00
k88936 added 4 commits 2026-09-03 14:42:54 +08:00
修复方向键长按取消后的点击状态 32c6e4ced8 
重置 pointercancel 和 pointerleave 的重复触发标记。

补充长按取消后点击仍可调整的回归测试。
限制方向键长按仅响应主指针 415240faa7 
忽略非主指针按钮的 pointerdown，避免右键触发连续调整。

补充非主键长按不产生调整的回归测试。
清理角点选择器未使用的定位字段 83c12c3b0b 
移除 CORNERS 中未被布局读取的 positionClass 死数据。
补充变换编辑器方向键交互约定
Project CI / Repository checks (pull_request) Failing after 1m3s
Details
Project CI / Frontend tests (pull_request) Successful in 3m33s
Details
Project CI / Backend tests (pull_request) Successful in 6m46s
Details
Project CI / Native shell tests (pull_request) Failing after 21m24s
Details
150628dcf9 
记录方向键主指针限制和长按取消状态清理语义。
k88936 dismissed kdletters's review 2026-09-03 14:42:54 +08:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

k88936 requested review from kdletters 2026-09-03 14:43:12 +08:00
k88936 added 1 commit 2026-09-03 16:08:42 +08:00
Merge branch 'master' into feat/ui-editor-better-offset-ui
Project CI / Repository checks (pull_request) Successful in 2m49s
Details
Project CI / Backend tests (pull_request) Successful in 6m26s
Details
Project CI / Frontend tests (pull_request) Successful in 3m19s
Details
Project CI / Native shell tests (pull_request) Successful in 20m57s
Details
fdda1de190
kdletters added 1 commit 2026-09-03 19:32:41 +08:00
Merge branch 'master' into feat/ui-editor-better-offset-ui
Project CI / Repository checks (pull_request) Successful in 2m53s
Details
Project CI / Frontend tests (pull_request) Successful in 3m20s
Details
Project CI / Backend tests (pull_request) Successful in 7m10s
Details
Project CI / Native shell tests (pull_request) Successful in 21m14s
Details
53bf991f24
kdletters scheduled this pull request to auto merge when all checks succeed 2026-09-03 19:33:24 +08:00
kdletters merged commit 4cd53688e9 into master 2026-09-03 19:36:18 +08:00
kdletters deleted branch feat/ui-editor-better-offset-ui 2026-09-03 19:36:18 +08:00
kdletters reviewed 2026-09-03 19:37:04 +08:00
kdletters left a comment
Member
Copy Link
Copy Source

审查 head sha: 53bf991f24

未发现明确问题。已检查该 head 相对 base cb7bc50ef9 的逐文件 diff，并结合现有调用方、Transform 数据契约和测试审查。已实际执行：目标 TransformEditor 测试 5/5 通过；ai-game-creator-shell typecheck 通过。

审查 head sha: 53bf991f24f1ae3cf1a6ced844e580fc4613fcb2 未发现明确问题。已检查该 head 相对 base cb7bc50ef90685b0e4924b78ceac2ab6aa4cead4 的逐文件 diff，并结合现有调用方、Transform 数据契约和测试审查。已实际执行：目标 TransformEditor 测试 5/5 通过；ai-game-creator-shell typecheck 通过。
kdletters commented 2026-09-03 19:41:00 +08:00
Member
Copy Link
Copy Source

审查 head sha: 53bf991f24

未发现明确问题。已检查该 head 相对 base cb7bc50ef9 的逐文件 diff，并结合现有调用方、Transform 数据契约和测试审查。已实际执行：目标 TransformEditor 测试 5/5 通过；ai-game-creator-shell typecheck 通过。

审查 head sha: 53bf991f24f1ae3cf1a6ced844e580fc4613fcb2 未发现明确问题。已检查该 head 相对 base cb7bc50ef90685b0e4924b78ceac2ab6aa4cead4 的逐文件 diff，并结合现有调用方、Transform 数据契约和测试审查。已实际执行：目标 TransformEditor 测试 5/5 通过；ai-game-creator-shell typecheck 通过。
Sign in to join this conversation.
Reviewers
No Reviewers
kdletters
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project 陶泥儿gameAgent
Assignees
Clear assignees
HuangJiaJia JenkenB k88936 (王德宇) kdletters (段舒康) laura2008 (王乐) lhk229 (孔令弘) Loer (农洛儿) loong suzmii (董羽秦) taobaisu (叶东旭) wuxiangwanzi (王子民) YixuanLiu ziyu
No Assignees k88936
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GenarrativeAI/Genarrative#265
Delete Branch "feat/ui-editor-better-offset-ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?